openrewrite/rewrite-templating

Support additional Refaster features seen in error-prone-support

Open

#47 opened on Dec 17, 2023

View on GitHubContributor guide
 (17 comments) (2 reactions) (0 assignees)Java (9 forks)auto 404
enhancementhelp wanted

Repository metrics

Stars
 (18 stars)
PR merge metrics
 (PR metrics pending)

Description

What problem are you trying to solve?

Expand the set of Refaster rules in Error Prone Support that we cover with OpenRewrite recipes.

Describe the solution you'd like

Support the following cases not currently covered.

  • com.google.errorprone.refaster.Refaster as seen in EqualityRules.java used ~326 times
    • #21
  • @UseImportPolicy as seen in MockitoRules.java used ~235 times
    • #53
    • #140
  • @DoNotCall as seen in TestNGToAssertJRules.java used 3 times
  • Generic type parameters are currently not supported as seen in ImmutableSortedMapRules.java used ~496 times
  • @AlsoNegation as seen in BigDecimalRules.java used ~19 times
  • @Placeholder as seen in LongStreamRules.java used ~15 times
  • @Repeated as seen in WebClientRules.java used ~9 times
  • @Matches & @NotMatches as seen in ReactorRules.java used ~1 + 2 times
  • "If statements are currently not supported" used ~8 times
  • "Lambdas are currently not supported" used ~2 times
  • "Method references are currently not supported" used ~1 times
  • Support of exclude templates that contain more than one statement, as the template matching would fail

Contributor guide

Research direction
Examine the existing Refaster rule translation logic in rewrite templating and identify the unimplemented features. Look for TODO comments, and check the test suite for examples of unsupported templates.
Tech stack
java
Domain
toolingdeveloper experience
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20