openrewrite/rewrite-apache

Spring 6+ upgrades trigger migration to HttpClient 5 – how to deal with undeclared dependency on HttpClient 4?

Open

#35 opened on Oct 16, 2024

View on GitHubContributor guide
 (5 comments) (0 reactions) (0 assignees)Java (20 forks)auto 404
bugenhancementgood first issuerecipe

Repository metrics

Stars
 (6 stars)
PR merge metrics
 (PR metrics pending)

Description

Discussed in https://github.com/openrewrite/rewrite/discussions/4584

Originally posted by @DidierLoiseau October 16, 2024 I noticed an issue with this migration, which is triggered transitively by Spring Boot 3+ upgrades since openrewrite/rewrite-spring#566: HttpClient 4 is a relatively common dependency, so people often use it without even realizing it is pulled transitively by another dependency, and they don’t declare HttpClient as an explicit dependency.

The problem with this migration is that it will update the code without adding the HttpClient 5 dependency if HttpClient 4 was missing.

Is there a way around this?

Contributor guide

Research direction
Examine the migration recipe to see if it handles the case where HttpClient 4 is an undeclared transitive dependency and ensure HttpClient 5 is added to the pom.xml.
Tech stack
java
Domain
backendapi
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaMavenSpring
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40