Missing clearPrivateParams from TS definitions

Open Beginner friendly
#1,710 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
1-3 hours
Newbie friendliness
84/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Quiet
Domain
api

Research direction

Start in openpgp.d.ts at the PrivateKey and SecretKeyPacket definitions, then compare them with clearPrivateParams() in src/key/private_key.js and src/packet/secret_key.js. Done means both TypeScript definitions expose the function consistently with the referenced JavaScript implementations.

Written by the indexing model from the issue text.

Description

TypeScript
  • OpenPGP.js version: 5.11.0
  • Affected platform (Browser or Node.js version): both

The typescript definitions for PrivateKey is missing the clearPrivateParams() function

The same is also true for the typescript definition of SecretKeyPacket.

Dominant language
JavaScript
Stars
6k
Forks
825
Avg merge
1d 12h
Merged PRs (30d)
8

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from openpgpjs/openpgpjs

All issues in openpgpjs/openpgpjs

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.