[MNT] Add Missing Assertions to Run Function Tests
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 82/100
- Issue type
- Refactor
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- python
- Domain
- testing-qa
Research direction
Start by reviewing the TODO comments and surrounding tests in tests/test_runs/test_run_functions.py, especially around lines 170, 287, 291, 341, 514, and 555. Add assertions for the holdout task type, runtime presence, and parameters as applicable, then run the relevant tests. Done means the intended checks are deterministic and the tests pass.
Written by the indexing model from the issue text.
Description
Several tests in test_run_functions.py have TODO comments indicating missing assertions (e.g., lines 170, 287, 291, 341, 514, 555). These include checks for holdout tasks, parameter presence, and runtime values, which would improve test reliability.
Steps:
- Review each TODO comment and the surrounding test code to understand what's being tested.
- Add appropriate assertions, such as:
assert task.task_type == "holdout"for holdout task checks.assert "runtime" in run.attributesfor runtime presence.assert len(run.parameters) > 0for parameter checks.
- Run the tests to ensure they pass and cover the intended behavior.
- If needed, mock or set up test data to make assertions deterministic.
Tests will be more comprehensive, catching regressions in run handling and parameter validation.
- Dominant language
- Python
- Stars
- 361
- Forks
- 296
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from openml/openml-python
-
Documentation Good First Issue
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
openml/openml-python#1708 · 6 comments ·
-
Good First Issue module:Data testing
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
openml/openml-python#1644 · 4 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
openml/openml-python#1714 · 1 comment ·
-
Difficulty 3/5 1-2 days Newbie friendliness 25/100
openml/openml-python#1711 · 1 comment ·
-
[MNT] `mypy` fixes Open
Difficulty 5/5 Over a week Newbie friendliness 30/100
openml/openml-python#1696 · 3 comments ·
All issues in openml/openml-python
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100