opengoofy/hippo4j

[Unit Test] Add test case for Joiner

Open

#1,328 opened on May 24, 2023

View on GitHub
 (3 comments) (0 reactions) (1 assignee)Java (4,972 stars) (1,100 forks)batch import
good first issuein: test

Description

Code classes that need to develop unit tests:

  • cn.hippo4j.common.toolkit.Joiner

Please refer to the manual for the first contribution: guide

Unit test development refers to the following two examples:

  • cn.hippo4j.core.executor.DynamicThreadPoolExecutorTest
  • cn.hippo4j.core.executor.ExtensibleThreadPoolExecutorTest

Contributor guide

Tech stack
java
Domain
testing
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Javaunit testing basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Examine the `Joiner` class in `cn.hippo4j.common.toolkit` to understand its methods. Review the example unit tests (`DynamicThreadPoolExecutorTest` and `ExtensibleThreadPoolExecutorTest`) for style and patterns. Write a test class `JoinerTest` covering typical usage and edge cases. No PRs are linked yet.