opengoofy/hippo4j

[Enhancement] Custom log printing Topic

Open

#1,230 opened on May 8, 2023

View on GitHub
 (7 comments) (0 reactions) (1 assignee)Java (4,972 stars) (1,100 forks)batch import
good first issuetype: enhancement

Description

Demand advice

Please answer these questions before submitting them. Thank you.

Is your function request related to the problem?

No.

Describe the function you want

The log is printed as follows.

WARN 26935 --- [           main] c.h.m.s.Hippo4jBaseSendMessageService    : [Tomcat] Please configure alarm notification on the server.

Hope to modify c.h.m.s.Hippo4jBaseSendMessageService to a more specific prompt, such as: Hippo4j-Send-Message.

WARN 26935 --- [           main] Hippo4j-Send-Message    : [Tomcat] Please configure alarm notification on the server.

TODO list:

  • Sort out the classes that trigger log printing when Hippo4j runs.
  • What is the name of the topic printed in the idea log.

Contributor guide

Tech stack
java
Domain
backend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
needs maintainer response
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Java basicsSLF4J/Logback understandingHippo4j project structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Locate the class Hippo4jBaseSendMessageService in the source code (likely under package com.hippo4j.monitor...) and understand how the logger is instantiated (e.g., LoggerFactory.getLogger(this.getClass())). Propose to replace the logger name with a custom string like 'Hippo4j Send Message'. Additionally, scan the whole codebase for other classes that print logs and consider consistent naming. Review the 7 comments on the issue for any maintainer feedback or naming suggestions. The TODO list also requires sorting out all classes that trigger log printing, so a thorough inventory is needed.