openfoodfacts/openfoodfacts-server

Move all images to the deleted folder when product is deleted without deleting individual images first

Open

#9,794 opened on Feb 13, 2024

View on GitHub
 (8 comments) (1 reaction) (0 assignees)Perl (477 stars) (236 forks)batch import
good first issue👮 Moderation

Description

What

  • Move all images to the deleted folder when product is deleted without deleting individual images first

Why

Code pointers

  • Related code is in lib/ProductOpener/Product.pm + Images.pm
  • To delete a product, you have to be an admin. Create a user in your local product opener website (use the Sign-in button), then in lib/ProductOpener/Config_off.pm add your userid.
  • Removing an image is calling process_image_move with "trash" as destination
  • Removing a product is about setting $product_ref->{deleted} to 'on', so image removal should happen in store_product, after initial checks, when we see it is deleted.

Contributor guide

Tech stack
None
Domain
backend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Perl basicsOpen Food Facts local setupFamiliarity with Product.pm and Images.pm
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Examine the store product function in lib/ProductOpener/Product.pm to detect when a product is being deleted (i.e., $product ref >{deleted} set to 'on'). Then, for each image associated with the product, call process image move from Images.pm with destination 'trash'. Ensure this happens before the product record is fully updated. The function signature and logic for moving images can be found in Images.pm.