openfoodfacts/openfoodfacts-server

Folksonomy Engine loads CSS and a font from CDNs

Open

#9,012 opened on Sep 17, 2023

View on GitHub
 (6 comments) (3 reactions) (0 assignees)Perl (477 stars) (236 forks)batch import
:star: :bug: top bug:star: top issueCSSJavaScriptgood first issue🎯 P1🏷️ Folksonomy Project

Description

https://github.com/openfoodfacts/openfoodfacts-server/blob/a0e358e7a79f55ed457d5676067e121ff7097416/html/js/folksonomy.js#L63-L65

image

For ProductOpener itself, we usually try to reduce the dependency on 3rd party CDNs. folksonomy.js does the opposite by loading three files from three different CDNs.

  1. jQuery UI is already bundled with ProductOpener
  2. FontAwesome could be revisited, because ProductOpener now mostly seems to use Material Icons since the redesign
  3. Bundle jqGrid, or replace it (if there's feature parity) with other grid already bundled?

Code pointers

You can find some code pointers here. If some are missing, feel free to add them yourself in this file, or to ask them.

Part of

  • #7525

Contributor guide

Tech stack
javascriptcss
Domain
frontend
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic JavaScriptunderstanding of CDN dependencies
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Examine the files mentioned: templates/web/common/includes/folksonomy script.tt.html and html/js/folksonomy.js. Identify which CSS and font files are loaded from CDNs (likely jQuery UI, FontAwesome, jqGrid). Check the existing bundles in ProductOpener (e.g., jQuery UI is already bundled) and propose replacing CDN links with local references or alternatives. No pull requests or maintainer responses are present yet.