openfaas/ofc-bootstrap

Use kubectl rollout status instead of looping

Open

#86 opened on Mar 15, 2019

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Go (61 forks)auto 404
good first issuehelp wantedskill/beginner

Repository metrics

Stars
 (177 stars)
PR merge metrics
 (PR metrics pending)

Description

We can use the blocking command

Expected Behaviour

We can use kubectl rollout status instead of looping to see if various services / deployments have come up / are ready. Found this out via @zeerorg

Current Behaviour

We are looping in code.

Possible Solution

Try out kubectl rollout status instead for things like checking cert-manager / SealedSecrets / Tiller etc are up and ready for the next stage.

Contributor guide

Research direction
Find the code that waits for deployments or services to become ready (likely using a loop with kubectl). Replace the loop logic with the blocking `kubectl rollout status` command. Ensure the same deployments are targeted and handle errors appropriately.
Tech stack
gokubernetes
Domain
clidevopsinfrastructure
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitGokubectl
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80