codex_mcp_interface.md approval section describes stale wire shape

Open Beginner friendly
#25,538 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
68/100
Issue type
Documentation
Clarity
Mostly clear
Activity status
Quiet
Tech stack
rust
Domain
api, documentation

Research direction

Start with codex-rs/docs/codex_mcp_interface.md and compare its approval section with the current MCP server implementation and MCP server tests. Confirm the elicitation/create request and review-decision response shape, then update the documentation or clearly mark the custom approval methods obsolete. Done means the documented wire shape matches the tested behavior.

Written by the indexing model from the issue text.

Description

documentation mcp
What happened?

codex-rs/docs/codex_mcp_interface.md documents approval requests as custom JSON-RPC methods:

applyPatchApproval { conversationId, callId, fileChanges, reason?, grantRoot? }
execCommandApproval { conversationId, callId, approvalId?, command, cwd, reason? }

and says clients should reply with:

{ "decision": "allow" | "deny" }

The current MCP server implementation appears to send elicitation/create requests for both exec and patch approvals instead. The MCP server tests also assert elicitation/create and respond with review-decision values, not the documented custom approval methods / allow or deny shape.

Expected behavior

The MCP interface documentation should describe the current approval wire shape, or clearly mark the listed custom approval methods as obsolete if they are no longer used.

Additional context

I searched open issues and PRs for terms including codex_mcp_interface, applyPatchApproval, execCommandApproval, and elicitation/create. I did not find an existing open item for this approval-section-specific doc drift. This is separate from #25518, which covers the broader app-server-vs-mcp-server RPC mismatch in the same document.

Dominant language
Rust
Stars
125k
Forks
19.5k
Avg merge
1m
Merged PRs (30d)
1k

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from openai/codex

All issues in openai/codex

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.