open-telemetry/opentelemetry-java

Create a separate module for JMH benchmarks

Open

#3,083 opened on Mar 31, 2021

View on GitHub
 (2 comments) (1 reaction) (0 assignees)Java (1,005 forks)auto 404
Feature Requesthelp wanted

Repository metrics

Stars
 (2,433 stars)
PR merge metrics
 (PR metrics pending)

Description

Is your feature request related to a problem? Please describe. There are multiple implementations of the SpanProcessor interface. I'd like to compare their performance to pick the one that best fulfils my requirements. Currently, one has to copy benchmarking classes like BatchSpanProcessorBenchmark, BatchSpanProcessorCpuBenchmark etc. Moreover, helper classes like BatchSpanProcessorMetrics also have to be copied. This leads to code duplication. When updating one class, one has to also update its clones.

Describe the solution you'd like I'd like to have a benchmarking module containing all common code: helper classes and benchmarks.

Describe alternatives you've considered Alternatively, we could leave code as it is right now.

Contributor guide

Research direction
Examine the existing benchmarking classes (e.g., BatchSpanProcessorBenchmark) and their helpers. Identify common code that can be extracted into a shared module. Plan the module structure with build configuration.
Tech stack
java
Domain
backendperformance
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaGradle
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70