open-telemetry/opentelemetry-dotnet

[OTLP] Determine specific conditions to consider when retrying export without a response from server.

Open

#5,425 opened on Mar 7, 2024

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C# (889 forks)auto 404
enhancementhelp wantedkeep-openpkg:OpenTelemetry.Exporter.OpenTelemetryProtocol

Repository metrics

Stars
 (3,725 stars)
PR merge metrics
 (PR metrics pending)

Description

Feature Request

In case when the response is not received from the server, HttpClient fails by throwing a HttpRequestException. In .NET 8.0, it is possible to further drill the error using HttpRequestError. Prior to this, such contract is not defined.

https://github.com/open-telemetry/opentelemetry-dotnet/pull/5394#discussion_r1508007233 brought up a point that we should probably not retry all exceptions which ends with no response. Opening this issue to further investigate and see if there is a better way to handle exceptions that ends with no response which can be use across all .NET versions.

Contributor guide

Research direction
Investigate the HttpRequestError enum in .NET 8 and older .NET versions to determine how to reliably detect no response errors. Propose a unified retry logic that works across .NET versions, potentially using reflection or compatibility shims.
Tech stack
csharp
Domain
backendobservability
Issue type
Research
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Needs investigation
Prerequisites
C#HTTP.NET
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30