open-telemetry/opentelemetry-dotnet

Improve instrument name validation and log messages

Open

#2,532 opened on Oct 27, 2021

View on GitHubContributor guide
 (2 comments) (0 reactions) (0 assignees)C# (889 forks)auto 404
enhancementhelp wantedkeep-openmetrics

Repository metrics

Stars
 (3,725 stars)
PR merge metrics
 (PR metrics pending)

Description

In PR #2470 we added validation for instrument and view names according to the spec. This issue is to track a small follow up that came up from PR comments :

Contributor guide

Research direction
Look at PR #2470 comments for discussion on guard helpers and log message improvements; implement guard helpers for name validation and enhance the log message to include the original invalid name.
Tech stack
csharp
Domain
observability
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC#
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70