open-source-parsers/jsoncpp

Use std::ostringstream for numeric formatting

Open

#419 opened on Feb 11, 2016

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C++ (7,542 stars) (2,602 forks)batch import
bughelp wanted

Description

We've had lots of problems with std::snprintf. E.g. #418.

As BillyGoto says:

Could we switch to std::ostringstream instead? Its numeric formatting is actually specified in terms of printf's output, and it's everywhere.

Contributor guide

Tech stack
cpp
Domain
backend
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic C++std::ostringstream familiarity
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
First, identify all uses of std::snprintf in the codebase, likely in files under src/lib json/. Replace each with std::ostringstream for numeric formatting. Ensure the output matches the expected JSON format and that existing tests pass. Refer to issue #418 for context on problems with snprintf. No open PRs or assignees, making this a clean task for a first time contributor.