open-source-parsers/jsoncpp

Use std::ostringstream for numeric formatting

Open

#419 opened on Feb 11, 2016

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C++ (2,602 forks)batch import
bughelp wanted

Repository metrics

Stars
 (7,542 stars)
PR merge metrics
 (Avg merge 18h 26m) (10 merged PRs in 30d)

Description

We've had lots of problems with std::snprintf. E.g. #418.

As BillyGoto says:

Could we switch to std::ostringstream instead? Its numeric formatting is actually specified in terms of printf's output, and it's everywhere.

Contributor guide

Research direction
Replace std::snprintf calls with std::ostringstream for numeric formatting. Ensure output format matches printf specifications.
Tech stack
cpp
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++STL
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75