open-keychain/open-keychain

NPE in ViewKeyAdvSubkeysFragment related to ECC

Open

#2045 opened on Feb 8, 2017

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Java (1,376 stars) (403 forks)batch import
google play crash-reporthelp wanted

Description

From Google Play dev console. I suspect this has to do with ECC subkeys.

java.lang.NullPointerException: Attempt to invoke virtual method 'boolean org.bouncycastle.asn1.ASN1ObjectIdentifier.equals(java.lang.Object)' on a null object reference
	at org.sufficientlysecure.keychain.ui.ViewKeyAdvSubkeysFragment$5.handleMessage(ViewKeyAdvSubkeysFragment.java:374)
	at android.os.Handler.dispatchMessage(Handler.java:102)
	at android.os.Looper.loop(Looper.java:158)
	at android.app.ActivityThread.main(ActivityThread.java:7229)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1230)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1120)

Contributor guide

Tech stack
javaandroid
Domain
mobile
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Android development setupOpenPGP fundamentalsBouncyCastle library basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
The NullPointerException occurs in ViewKeyAdvSubkeysFragment.java at line 374 inside the handleMessage method, where an ASN1ObjectIdentifier is null. The issue likely arises when handling ECC subkeys that may not have a valid algorithm identifier. To fix, investigate the code path leading to the null object, perhaps by checking if the subkey's key algorithm is null before calling equals. Review the ECC subkey handling logic and ensure proper null checks. No linked PRs or comments provide additional context.