open-keychain/open-keychain

Crash with "Rank 0 user packet must be a user id!"

Open

#1853 opened on May 6, 2016

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Java (1,376 stars) (403 forks)batch import
bughelp wanted

Description

Hi,

I am stuck with a 'broken' Open-Keychain update on my phone. When opening the application it will try to reimport the keys and crashes at around 65%. I have several secret keys and >300 public keys.

Stacktrace from logcat:

E/AndroidRuntime(20571): FATAL EXCEPTION: Thread-48963
E/AndroidRuntime(20571): Process: org.sufficientlysecure.keychain, PID: 20571
E/AndroidRuntime(20571): java.lang.AssertionError: Rank 0 user packet must be a user id!
E/AndroidRuntime(20571):        at org.sufficientlysecure.keychain.provider.KeychainProvider.insert(KeychainProvider.java:810)
E/AndroidRuntime(20571):        at android.content.ContentProviderOperation.apply(ContentProviderOperation.java:214)
E/AndroidRuntime(20571):        at android.content.ContentProvider.applyBatch(ContentProvider.java:1617)
E/AndroidRuntime(20571):        at android.content.ContentProvider$Transport.applyBatch(ContentProvider.java:260)
E/AndroidRuntime(20571):        at android.content.ContentProviderClient.applyBatch(ContentProviderClient.java:377)
E/AndroidRuntime(20571):        at android.content.ContentResolver.applyBatch(ContentResolver.java:1233)
E/AndroidRuntime(20571):        at org.sufficientlysecure.keychain.provider.ProviderHelper.saveCanonicalizedPublicKeyRing(ProviderHelper.java:730)
E/AndroidRuntime(20571):        at org.sufficientlysecure.keychain.provider.ProviderHelper.savePublicKeyRing(ProviderHelper.java:978)
E/AndroidRuntime(20571):        at org.sufficientlysecure.keychain.operations.ImportOperation.serialKeyRingImport(ImportOperation.java:321)
E/AndroidRuntime(20571):        at org.sufficientlysecure.keychain.operations.ImportOperation.serialKeyRingImport(ImportOperation.java:101)
E/AndroidRuntime(20571):        at org.sufficientlysecure.keychain.provider.ProviderHelper.consolidateDatabaseStep2(ProviderHelper.java:1357)
E/AndroidRuntime(20571):        at org.sufficientlysecure.keychain.provider.ProviderHelper.consolidateDatabaseStep2(ProviderHelper.java:1259)
E/AndroidRuntime(20571):        at org.sufficientlysecure.keychain.operations.ConsolidateOperation.execute(ConsolidateOperation.java:43)
E/AndroidRuntime(20571):        at org.sufficientlysecure.keychain.operations.ConsolidateOperation.execute(ConsolidateOperation.java:31)
E/AndroidRuntime(20571):        at org.sufficientlysecure.keychain.service.KeychainService$1.run(KeychainService.java:146)
E/AndroidRuntime(20571):        at java.lang.Thread.run(Thread.java:841)

Unfortunately I couldn't find out yet which key is affected.

Maybe related to #1660? There are a couple of revoked keys (pub and sec) in my keyrings.

Contributor guide

Tech stack
javaandroid
Domain
mobilesecurity
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
Android developmentJavaOpenPGP concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the assertion failure at KeychainProvider.java:810. The crash occurs during saveCanonicalizedPublicKeyRing when a user packet is not a user ID. Check the keyring import logic in ImportOperation.serialKeyRingImport and ProviderHelper.savePublicKeyRing. Look at related issue #1660 for revoked keys handling. Determine which key causes the issue by adding logging or using a debug build.