open-keychain/open-keychain

java.lang.AssertionError: cannot clearsign in non-ascii armored text, this is a bug!

Open

#1654 opened on Jan 3, 2016

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Java (1,376 stars) (403 forks)batch import
bughelp wanted

Description

From Google Play dev console.

Message from user: just crashes when trying to access with another app.

java.lang.AssertionError: cannot clearsign in non-ascii armored text, this is a bug!
    at org.sufficientlysecure.keychain.pgp.PgpSignEncryptOperation.execute(PgpSignEncryptOperation.java:501)
    at org.sufficientlysecure.keychain.remote.OpenPgpService.encryptAndSignImpl(OpenPgpService.java:437)
    at org.sufficientlysecure.keychain.remote.OpenPgpService.executeInternalWithStreams(OpenPgpService.java:874)
    at org.sufficientlysecure.keychain.remote.OpenPgpService.executeInternal(OpenPgpService.java:829)
    at org.sufficientlysecure.keychain.remote.OpenPgpService2$1.execute(OpenPgpService2.java:62)
    at org.openintents.openpgp.IOpenPgpService2$Stub.onTransact(IOpenPgpService2.java:80)
    at android.os.Binder.execTransact(Binder.java:446)

Contributor guide

Tech stack
javaandroid
Domain
mobilesecurity
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
JavaAndroid developmentOpenPGP conceptsASCII armor
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25
Research direction
The crash occurs in PgpSignEncryptOperation.java at line 501 during clearsign operation with non ASCII armored text. Investigation should focus on how the input text is encoded and whether the ASCII armoring process can handle non ASCII characters. The assertion is thrown when trying to clearsign non ASCII armored text. A potential fix might involve handling character encoding before signing, or allowing non ASCII in clearsign. Check the PgpSignEncryptOperation implementation and related encoding utilities.