open-feature/flagd

[CHORE] grpc_sync.go is hard to test

Closed

#1,562 opened on Feb 14, 2025

View on GitHubContributor guide
 (1 comment) (2 reactions) (0 assignees)Go (118 forks)github user discovery
help wanted

Repository metrics

Stars
 (925 stars)
PR merge metrics
 (Avg merge 3d 9h) (8 merged PRs in 30d)

Description

https://github.com/open-feature/flagd/blob/main/core/pkg/sync/grpc/grpc_sync.go makes calls to grpc (e.g. NewClient) and different parameters are set based on grpc.Sync configuration. Ideally, we would test whether than configuration affects the calls to grpc, for example by using mocks.

Contributor guide

Research direction
Examine grpc sync.go to understand how gRPC configuration affects client creation, then write unit tests with a mock gRPC client.
Tech stack
go
Domain
backend
Issue type
Chore
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Gotestingmocks
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75