open-feature/flagd

[FEATURE] Improve evaluation performance

Open

#1,453 opened on Nov 20, 2024

View on GitHubContributor guide
 (8 comments) (1 reaction) (1 assignee)Go (118 forks)github user discovery
enhancementgood first issuehelp wanted

Repository metrics

Stars
 (925 stars)
PR merge metrics
 (Avg merge 3d 9h) (8 merged PRs in 30d)

Description

Overview

The flag evaluation engine in flagd leverages JsonLogic to provide a powerful and flexible rule-based serializable logic. The flagd binary and in-process Go flagd provider use this library. To improve flag evaluation performance and reduce computational overhead, the ruleset should be pre-decoded when a flag set is loaded (or updated). This removes the need to parse the JsonLogic structure for each evaluation.

### Tasks
- [ ] [Add support for pre-decoded rules in the Go JsonLogic SDK](https://github.com/diegoholiveira/jsonlogic/issues/88).
- [ ] Update flagd to use the pre-decoded rules.
- [ ] 🥇 Bonus points for running a performance test to measure the improvements

This should be a non-breaking change in the Go JsonLogic SDK.

Contributor guide

Research direction
Investigate the JsonLogic Go SDK to understand how to add support for pre decoded rules, then update flagd to use them. Measure performance improvements.
Tech stack
go
Domain
backend
Issue type
Performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
GoGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40