open-duelyst/duelyst

[P2] Uncaught TypeError: WebGLRenderingContext.bindBuffer: Argument 2 is not an object.

Open

#97 opened on Oct 4, 2022

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (3,443 stars) (526 forks)batch import
bugfrontendhelp wanted

Description

Summary

Noticed this error + stack trace while playing a practice game locally:

Uncaught TypeError: WebGLRenderingContext.bindBuffer: Argument 2 is not an object.
    postStep vendor.js:52124
    postStep vendor.js:51396
    update BaseParticleSystem.js:1337
    resetSystem BaseParticleSystem.js:1163
    updateSourceToTarget BaseParticleSystem.js:584
    setSourceScreenPosition BaseParticleSystem.js:250
    onResize BattleMap.js:303
    triggerEvents eventbus.js:156
    trigger eventbus.js:89
    resize Scene.js:270
    onResize application.coffee:3489
    later vendor.js:16021
    setTimeout handler*later vendor.js:16017
    setTimeout handler*later vendor.js:16017
    setTimeout handler*_.debounce/< vendor.js:16033
    dispatch vendor.js:4676
    handle vendor.js:4360
vendor.js:52124:8

I'm not sure what the impact is, yet. It seems specific to BattleMap.js.

Impacted services

[x] The frontend app [ ] The game servers [ ] Game builds or automation scripts [ ] Tests or Github Actions [ ] Infrastructure (Terraform)

Steps to reproduce

  1. Play a practice game; should appear in the console.

Environment information

  • Operating system: Mac
  • Browser: Firefox
  • Browser version: 105.0.1

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic JavaScriptunderstanding of WebGL concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55
Research direction
Investigate the stack trace: the error originates from BattleMap.js's onResize, which calls BaseParticleSystem's setSourceScreenPosition. The error 'Argument 2 is not an object' suggests a null or undefined buffer object is passed to bindBuffer. Look at the particle system's buffer management during resize events, particularly in BaseParticleSystem.js lines 250, 584, and 1163. Check if the buffer is properly initialized or reused after the canvas resizes.