open-duelyst/duelyst

[P3] Replace node-redis with ioredis

Open

#80 opened on Oct 2, 2022

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (3,443 stars) (526 forks)batch import
backendenhancementhelp wanted

Description

We're currently using node-redis@2.8.0, which has poor support for connection timeouts.

Replacing this with ioredis@5.2.3 fixes the above, but requires some changes. For example, the zrevrankAsync function does not exist, so we need to use zrevrank instead and remove the .then(result) chain.

Alternatively, upgrading node-redis may help with these issues.

See https://github.com/luin/ioredis/wiki/Migrating-from-node_redis

Contributor guide

Tech stack
javascriptnodejsredis
Domain
backenddatabase
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Node.jsRedis basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Review the migration guide at https://github.com/luin/ioredis/wiki/Migrating from node redis. Replace node redis with ioredis in the codebase, particularly update methods like `zrevrankAsync` to `zrevrank` and remove `.then()` chains. Check all Redis calls to ensure compatibility.