open-duelyst/duelyst

[P2] Bots can have partial or empty decks in practice mode

Open

#261 opened on Jan 14, 2023

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (3,443 stars) (526 forks)batch import
backendbughelp wanted

Description

Summary

I started a Practice Duel against Faie, setting "Difficulty" to 100% and "Random cards" to 40 and she started the game with only the cards in her starter hand and empty deck. Next try everything was fine, but her deck started at 26/40 (so 10 cards short).

Impacted services

  • The frontend app
  • The game servers
  • Game builds or automation scripts
  • Tests or Github Actions
  • Infrastructure (Terraform)

Steps to reproduce

Environment information

  • Operating system: Windows,
  • Desktop client, latest

Additional context

Contributor guide

Tech stack
javascript
Domain
frontendbackend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
JavaScriptgame logic familiaritylocal development setup
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Investigate the deck construction logic for AI opponents in practice mode, focusing on how the bot's deck size is initialized and how the 'Difficulty' and 'Random cards' settings affect it. Look for race conditions or missing cards in the deck building code. Examine both the game server and frontend for potential causes of the intermittent behavior.