open-duelyst/duelyst

[P1] Enable linting for ESLint override files

Open

#26 opened on Sep 10, 2022

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (3,443 stars) (526 forks)batch import
backendenhancementfrontendhelp wanted

Description

We have several files with overrides set in .eslintrc.json:

    {
      "files": ["app/**/*.js"],
      "rules": {"camelcase": ["warn"]}
    },
    {
      "files": ["test/**/*.js"],
      "rules": {"no-unused-expressions": ["off"]}
    }

We should remove these overrides and resolve the underlying linting issues.

Contributor guide

Tech stack
javascriptnodejs
Domain
tooling
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptESLintnpm
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
The issue requires modifying the .eslintrc.json file to remove the 'files' overrides for app/**/*.js and test/**/*.js, then running ESLint and fixing any resulting linting errors in those files. The changes are localized and well defined.