open-duelyst/duelyst

[P3] Repair and re-enable disabled SDK unit tests

Open

#25 opened on Sep 10, 2022

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (3,443 stars) (526 forks)batch import
backendenhancementfrontendhelp wanted

Description

Several unit tests have been disabled until we have time to go back and update them. search for Test disabled in the repo to find them:

% git grep -l 'Test disabled'
test/unit/sdk/ai/ai.js
test/unit/sdk/ai/bosses.js
test/unit/sdk/cards/bloodstorm/faction6.js
test/unit/sdk/cards/bloodstorm/neutrals.js
test/unit/sdk/cards/core/faction2/artifacts.js
test/unit/sdk/cards/core/faction3/minions.js
test/unit/sdk/cards/core/faction5/spells.js
test/unit/sdk/cards/core/neutrals/epics.js
test/unit/sdk/cards/coreshatter/faction1.js
test/unit/sdk/cards/misc/bloodborn_spells.js
test/unit/sdk/cards/monthlies/month7.js
test/unit/sdk/cards/monthlies/month9.js
test/unit/sdk/cards/monthlies/seven_sisters.js
test/unit/sdk/cards/shimzar/battle_pets.js
test/unit/sdk/cards/shimzar/faction1.js
test/unit/sdk/cards/shimzar/faction2.js
test/unit/sdk/cards/shimzar/faction4.js
test/unit/sdk/cards/shimzar/faction5.js
test/unit/sdk/cards/unity/faction5.js
test/unit/sdk/cards/unity/faction6.js
test/unit/sdk/cards/wartech/faction2.js
test/unit/sdk/cards/wartech/faction3.js
test/unit/sdk/cards/wartech/faction4.js
test/unit/sdk/cards/wartech/faction5.js
test/unit/sdk/game/basic.js

We should revisit these and turn them back on once we get them working.

Contributor guide

Tech stack
javascript
Domain
testing
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScript programmingUnit testing experienceNode.js environment setup
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55
Research direction
First, use git grep to locate files containing 'Test disabled' as listed in the issue (e.g., test/unit/sdk/ai/ai.js). For each file, examine the disabled test(s) and understand the logic. Look for comments or recent changes that caused the test to fail. Update the test code to fix any issues and remove the 'Test disabled' marker. Ensure all tests pass. The repository uses JavaScript and likely a testing framework like Mocha or Jest—check package.json for details. No linked PRs or assignees exist, so this is open for taking.