open-duelyst/duelyst

[P2] Add password reset tokens

Open

#152 opened on Oct 16, 2022

View on GitHub
 (1 comment) (1 reaction) (0 assignees)JavaScript (3,443 stars) (526 forks)batch import
backendenhancementhelp wanted

Description

Summary

Since we removed email-based forgot password flows (see git log for original code), we should add an alternative system for password resets. One way to do this is with "recovery tokens", as seen on sites with MFA flows. We could give a user one recovery token which can be used to validate a one-time password reset, which then grants a new recovery token. These could be stored as (user_id, token) in a new Postgres table, and can be deleted after successful use.

Contributor guide

Tech stack
javascriptpostgresql
Domain
backendauthentication
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptBasic SQLAuthentication concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Examine the existing authentication flow in the repository to understand how sessions are managed and where token validation occurs. Look for the previous email based forgot password code in git history. Implement a new Postgres table for recovery tokens with user id and token fields, and create endpoints to generate and validate tokens. Ensure tokens are hashed before storage and deleted after successful use.