open-duelyst/duelyst

[P3] Upgrade Electron in Desktop builds

Open

#138 opened on Oct 14, 2022

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (3,443 stars) (526 forks)batch import
enhancementhelp wanted

Description

Summary

We currently use Electron v2. The latest version is v21. Support for arm64 Macs was added in v11.

Upgrading directly to v11 cause the app to fail to start on Mac, so let's see what changes are needed to make this upgrade happen.

Contributor guide

Tech stack
javascriptnodejs
Domain
desktop
Issue type
chore
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
Basic JavaScriptFamiliarity with ElectronKnowledge of desktop build processes
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25
Research direction
Investigate the current Electron version (v2) and the build configuration in the repository. Identify breaking changes between v2 and v11, especially around macOS arm64 support. Look at the main process setup and any native modules that may need updating. Check if there are any open issues or PRs related to Electron upgrade.