onivim/oni

ctrl-c in cmd kills oni - closing cmd also closes oni

Open

#970 opened on Nov 17, 2017

View on GitHubContributor guide
 (4 comments) (0 reactions) (0 assignees)TypeScript (297 forks)batch import
bughelp wanted

Repository metrics

Stars
 (11,246 stars)
PR merge metrics
 (PR metrics pending)

Description

Oni seems somehow to be attached to its parent process:

ctrl-c in cmd kills oni

Open cmd on windows 10

Start oni:

oni

do dir or some other command.

do ctrl-c in cmd and oni will exit

Expected: oni is not affected by cmd

closing cmd also closes oni

Open cmd on windows 10 start oni:

oni

close cmd window -> oni will exit

Expected: oni is not affected by cmd

Contributor guide

Research direction
Investigate how Oni spawns child processes and whether it uses process groups or detaches from console. Focus on the startup code that launches Oni and any signal handling for Ctrl+C.
Tech stack
typescriptnodejselectron
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
GitNode.jsElectron
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70