onivim/oni

Unicode characters wrapping

Open

#926 opened on Nov 12, 2017

View on GitHub
 (2 comments) (0 reactions) (0 assignees)TypeScript (336 forks)batch import
bughelp wantedi18ninsider

Repository metrics

Stars
 (11,389 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

It looks like some unicode characters are still causing issues in Oni for me.

image

I was writing up the Keybinds page for the Wiki and noticed that using the ⌘ character caused a few issues, in both the editor itself as well as the command pallet when I was using it to search and replace.

You can see in Oni it looks like the keybinds are missing characters, but in Notepad++ all the characters are there (though it can't display the unicode at all).

Contributor guide

Research direction
Investigate the Unicode rendering in the editor by tracing the display logic for keybindings and command palette. Check how character widths are measured and if there is any special handling for multi byte characters.
Tech stack
typescript
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40