onivim/oni

Unicode characters wrapping

Open

#926 opened on Nov 12, 2017

View on GitHub
 (2 comments) (0 reactions) (0 assignees)TypeScript (11,389 stars) (336 forks)batch import
bughelp wantedi18ninsider

Description

It looks like some unicode characters are still causing issues in Oni for me.

image

I was writing up the Keybinds page for the Wiki and noticed that using the ⌘ character caused a few issues, in both the editor itself as well as the command pallet when I was using it to search and replace.

You can see in Oni it looks like the keybinds are missing characters, but in Notepad++ all the characters are there (though it can't display the unicode at all).

Contributor guide

Tech stack
typescriptnodejsreact
Domain
frontenddesktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Familiarity with Oni's rendering pipelineUnderstanding of Unicode character width
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate Oni's text rendering code, likely in the Editor component (src/Editor/). The issue involves Unicode characters like ⌘ not wrapping correctly. Check if the rendering uses a fixed width assumption; consider using a library like 'wcwidth' to calculate display widths. Review comments in the issue for any suggested approaches. No linked PRs exist, so the fix would need to be implemented from scratch.