onivim/oni

Closing window leaves behind swap files

Open

#670 opened on Aug 28, 2017

View on GitHub
 (1 comment) (1 reaction) (0 assignees)TypeScript (11,389 stars) (336 forks)batch import
bughelp wanted

Description

Whenever I close the Oni window all files that were being actively edited leave behind swap files. Whenever I go to edit the files again I'm greeted with a message like this:

image

When I exit using :q as any vim veteran would do habitually, no swap file is left behind.

I'm on Windows 10

Contributor guide

Tech stack
typescript
Domain
desktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic knowledge of Neovim swap files
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate the event handler for window close in Oni's source code (likely in the main Electron process). The issue suggests that closing the window via UI does not trigger a proper Vim exit (e.g., ':q'). Look at how the application handles the 'beforeunload' or 'close' event and compare with the behavior when ':q' is executed. The fix may involve ensuring the Neovim instance is properly shut down when the window is closed.