onivim/oni

Can we move away from emulating neovim behavior for scrolling?

Open

#405 opened on Apr 26, 2017

View on GitHub
 (11 comments) (9 reactions) (0 assignees)TypeScript (11,389 stars) (336 forks)batch import
enhancementhelp wantedinsider

Description

I think the Grid implementation is a bit bad, and I don't mean that from an implementation perspective. The scrolling in oni, in my opinion, isn't worse than neovim. At least for me, it feels about the same. If we could somehow render a large (basically render ahead to a certain arbitrary point where it becomes not worth the benefit) portion of the Grid implementation but make it all on an actually scrollable page, we could just send a cursor position back to Neovim instead of sending scroll events. The issue with scroll events is that (especially on OSX) on modern laptops that have fast/inertia scrolling, it's just firing off too many times in a second.

Contributor guide

Tech stack
typescript
Domain
frontendperformance
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Understanding of Oni Grid implementationFamiliarity with Neovim RPCExperience with rendering in TypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25
Research direction
Examine the current Grid implementation in the Oni codebase, likely in the src/ directory, to understand how scrolling events are generated and handled. Review the comments on issue #405 for proposed alternatives, such as rendering a larger buffer and sending cursor position. Consider the performance implications of this change, especially on macOS with inertia scrolling. Look for any existing branches or discussions that might provide a starting point.