onivim/oni

Sporadic CI failures

Open

#2730 opened on Feb 28, 2019

View on GitHub
 (1 comment) (0 reactions) (0 assignees)TypeScript (11,389 stars) (336 forks)batch import
good first issuehelp wantedinsiderlowering the bar

Description

Looking for help from the community regarding this issue.

Issue: Sporadic CI failures.

Expected behavior: Consistent CI results.

Actual behavior: CI test may fail or pass with a rerun and no other change.

Steps to reproduce: Run CI repeatedly by opening a PR and re-pushing minor changes until reproduced.

Reference issue: https://travis-ci.org/onivim/oni/jobs/499977978

Specifically for the example above:

ci tests AutoClosingPairsTest ci test: AutoClosingPairsTest:
Error: timeout of 120000ms exceeded. Ensure the done() callback is being called in this test.

Contributor guide

Tech stack
typescriptnodejs
Domain
testingdevops
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
over 1 week
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
basic test framework knowledgeCI debugging skills
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Examine the AutoClosingPairsTest in the test suite. Look for asynchronous code not properly awaited or race conditions. Investigate the CI environment (likely Travis) for timeouts. Consider reducing test timeout or implementing retries. Check if there are existing fixes in other branches or PRs.