onivim/oni

Interactive tutorial broken in version 0.3.7 and 0.3.8

Open

#2688 opened on Dec 17, 2018

View on GitHub
 (12 comments) (17 reactions) (0 assignees)TypeScript (11,389 stars) (336 forks)batch import
help wanted

Description

Oni Version: 0.3.8 Neovim Version (Linux only): 0.3.1 Operating System: Ubuntu 18.04 x64

Issue: Interactive tutorial doesn't work. Unable to complete first task int first tutorial.

Expected behavior: Interactive tutorial inline window goes into insert mode and input text goes to that window

Actual behavior: When I press i key to switch into insert mode inside interactive tutorial inline window, whole Tutorial tab goes into insert mode and input text goes somewhere in background

Steps to reproduce: Open first task in first tutorial, press i. Whole tab goes into insert mode instead of inline window

Contributor guide

Tech stack
typescriptreactcss
Domain
frontenddocumentation
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic knowledge of TypeScriptunderstanding of Neovim insert mode
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the interactive tutorial component, likely in the 'browser/src/UI/tutorial' directory. Check how the inline window handles key events and insert mode. Look at recent changes around version 0.3.7-0.3.8 that may have introduced the regression. The comment thread may contain insights from maintainers about potential fixes.