onivim/oni

Prompt before closing modified buffers

Open

#264 opened on Mar 1, 2017

View on GitHub
 (13 comments) (0 reactions) (0 assignees)TypeScript (11,389 stars) (336 forks)batch import
bountybounty-25enhancementhelp wantedinsiderneovim-core

Description

When closing a buffer from the menu (Quit, Close, Split -> Close, Close Other Split(s)) Oni needs to prompt to save if the buffer is modified. For some operations (Close, Split -> Close) we just need to check if the current buffer is dirty but for other operations (Quit, Close Other Split(s)) we need to see if any buffer is dirty.

Contributor guide

Tech stack
typescript
Domain
frontenddesktop
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Knowledge of TypeScriptUnderstanding of buffer management in Oni
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Review the current implementation of buffer closing in the menu actions (Quit, Close, Split > Close). Identify where the dirty state of buffers is tracked and how the editor decides whether to prompt. Check the issue comments for any proposed solutions or discussions. Note that the issue is from 2017, so the codebase may have changed; look at the current buffer management module (likely in src/Buffer/) to understand the architecture.