onivim/oni

Prompt before closing modified buffers

Open

#264 opened on Mar 1, 2017

View on GitHub
 (13 comments) (0 reactions) (0 assignees)TypeScript (336 forks)batch import
bountybounty-25enhancementhelp wantedinsiderneovim-core

Repository metrics

Stars
 (11,389 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

When closing a buffer from the menu (Quit, Close, Split -> Close, Close Other Split(s)) Oni needs to prompt to save if the buffer is modified. For some operations (Close, Split -> Close) we just need to check if the current buffer is dirty but for other operations (Quit, Close Other Split(s)) we need to see if any buffer is dirty.

Contributor guide

Research direction
Look at the menu actions for Close, Quit, etc. in the codebase. Trace the buffer close functions to find where to add a save prompt. Check if there's a dirty flag on buffers and implement logic to prompt for unsaved changes.
Tech stack
typescript
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65