onivim/oni

Textmate Highlighting: Visual mode selection does not have correct background

Open

#2,629 opened on Oct 12, 2018

View on GitHub
 (0 comments) (2 reactions) (0 assignees)TypeScript (336 forks)batch import
help wantedinsider

Repository metrics

Stars
 (11,389 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Reported by @josemarluedke on discord.

Oni Version: v0.3.7 Operating System: Windows

Issue:

With textmate highlighting active, you see this: image

And he also tested out gruvbox dark: image

On my machine / config with gruvbox_dark, I see this: image

Steps to reproduce:

  • This reproduces both with gruvbox_dark and dracula themes

There's potentially an issue with how we're synchronizing colors / schemes to Neovim.

Contributor guide

Research direction
Investigate how Oni synchronizes color schemes to Neovim, focusing on the integration of Textmate highlighting. Look at the code that applies colors to visual mode selection and identify why the background color is incorrect. Trace the flow from theme loading to Neovim color setting.
Tech stack
typescript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70