onivim/oni

Textmate Highlighting: Visual mode selection does not have correct background

Open

#2629 opened on Oct 12, 2018

View on GitHub
 (0 comments) (2 reactions) (0 assignees)TypeScript (11,389 stars) (336 forks)batch import
help wantedinsider

Description

Reported by @josemarluedke on discord.

Oni Version: v0.3.7 Operating System: Windows

Issue:

With textmate highlighting active, you see this: image

And he also tested out gruvbox dark: image

On my machine / config with gruvbox_dark, I see this: image

Steps to reproduce:

  • This reproduces both with gruvbox_dark and dracula themes

There's potentially an issue with how we're synchronizing colors / schemes to Neovim.

Contributor guide

Tech stack
typescript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Understanding of textmate grammar highlightingFamiliarity with Neovim color scheme synchronization
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
Investigate how textmate colors are being synchronized to Neovim in the Oni codebase. Look at the color scheme handling code, possibly in files related to textmate or Neovim integration. The screenshots show incorrect background in visual mode, so the issue might be in how the 'Visual' highlight group is being mapped. Check recent changes or existing issues about color synchronization.