onivim/oni

React/Redux DevTools no longer working

Open

#2611 opened on Oct 4, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)TypeScript (11,389 stars) (336 forks)batch import
developmentgood first issueinsiderregression

Description

The react and redux devtools seem to have regressed and are no longer available in dev. I think this might be due to a broken env variable OR the package might have changed and does not export the tools in the same way anymore.

My suggestion for anyone looking to tackle this would be to have a look at the DevToolsInstaller and confirm that the installer is being called and that the tools are correctly imported (I suspect they are undefined as we using a dynamic import which is likely broken due to a recent webpack upgrade)

Contributor guide

Tech stack
typescriptreact
Domain
frontenddeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Understanding of React/Redux DevToolsFamiliarity with dynamic imports in Webpack
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25
Research direction
Examine the DevToolsInstaller component in the codebase to confirm it is being called. Check if the dynamic import for React/Redux DevTools is broken due to a recent Webpack upgrade, as suspected. Also verify that the development environment variable is set correctly. Review any comments or linked PRs for additional context.