onivim/oni

Oni can't open and operate with files/folder with special chars in name

Open

#2508 opened on Aug 16, 2018

View on GitHub
 (6 comments) (0 reactions) (0 assignees)TypeScript (11,389 stars) (336 forks)batch import
0.3.8buggood first issue

Description

Oni Version: 0.36 64bit zipped Operating System: Windows 7 64bit

Issue: Oni struggles to operate with any file/folder with a # char in name. I've stumbled on this issue because I have a couple of log files named like foo#1234.log. Fiddling around a little bit more I found also that issues arise with folders named with a #.
Ex: C:\path\#hashed\file.txt is opened as a blank tab in Oni. Error reported in dev tool console is:

Error: ENOENT: no such file or directory, stat 'C:\path#hashed\file.txt'
                                                       ^ notice the collapsed \

My best guess is there is some regex or glob snafu going on. Out of curiosity I've tried a bunch of special chars and the following have the same issue, but maybe there are others like funky emojis\unicodes or similar:

# % ^ & ; ` '

I guess these are some niche cases, but maybe this is a symptom of something bigger lurking in the file scan logic.

Let me now if I can do something else!

Steps to reproduce: Just create a bunch of files in a folder, name a few with a #, like #test.txt, Oni will not be able to open them.

Contributor guide

Tech stack
typescriptnodejs
Domain
desktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
TypeScriptNode.js file system
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate how Oni opens files, likely through Neovim's API or Node.js fs module. Check if the issue is caused by improper escaping of special characters in file paths. Look for related regex or glob patterns in the codebase that may strip or mishandle '#' characters. Also verify if the issue persists in the latest version.