onivim/oni

Enhancement/Markdown preview code blocks styling

Open

#2475 opened on Jul 29, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (11,389 stars) (336 forks)batch import
Feature-requestenhancementgood first issueinsider

Description

Oni Version: Neovim Version (Linux only): Operating System:

Issue: Having taken to using the markdown previewer more since at @CrossR's updates and finally writing some docs for new features I note some things about the markdown previewer. Code blocks render with a default font which doesn't match any of a user's choices. There is also no padding on the elements so text tightly within the code block. Expected behavior: Code blocks should have font-family: user-text-font-family and have some small padding applied to them.

Contributor guide

Tech stack
typescriptreact
Domain
frontenddeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic CSSfamiliarity with project's styling approach
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Locate the markdown preview component in the repository, likely in the 'src' directory. Look for CSS or styled components related to the markdown previewer. Add styling for code blocks to use the user's text font family and apply padding. The issue mentions 'font family: user text font family' and padding. Check if there is a global variable for user font or if it needs to be passed down.