onivim/oni

Changing themes is buggy

Open

#2,470 opened on Jul 27, 2018

View on GitHub
 (8 comments) (1 reaction) (0 assignees)TypeScript (11,389 stars) (336 forks)batch import
0.3.8buggood first issue

Description

Oni Version: 0.3.6 Neovim Version (Linux only): Operating System: Microsoft Windows 10 x64 v1709, build nº16299.15

Issue: Changing themes is buggy and laggy it slows Oni down so much.

Expected behavior: Like in VSCode or Atom, when i select a theme, it instantaneously changes the actual theme to the new i selected. In Oni, this doesn't happen.

Actual behavior: It takes so much to change between themes, when i select one in the command palette, the screen flashes and the theme starts to load slowly. After about 5-10 seconds i can use Oni normally again.

Steps to reproduce: Just open up the command palette and select Themes => Choose theme and select any theme from the list.

I understand that this is still an experimental / beta version, but even with all the bugs, the development team is to be congratulated! It really is a beautiful job! Thank you :) 👍

Contributor guide

Tech stack
typescript
Domain
desktopfrontendperformance
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
TypeScriptOni theming systemperformance profiling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the theme loading mechanism in Oni, likely in the UI layer (React or similar). Look at how theme changes trigger updates, possibly involving JSON parsing and CSS injection. Use browser developer tools (if applicable) or Node.js profiling to identify bottlenecks. The issue has no assigned developer, so it is open for contribution. Check the comments for any prior investigation.