onivim/oni

Language server over TCP

Open

#2,350 opened on Jun 24, 2018

View on GitHub
 (3 comments) (0 reactions) (0 assignees)TypeScript (11,389 stars) (336 forks)batch import
enhancementhelp wantedperformance

Description

As per https://langserver.org/ , language_server-ruby is very basic where as https://github.com/castwide/solargraph supports more capabilities.

Solargraph, however, only supports TCP; the author is suggesting he was getting more performant results over TCP vs stdio, this is why he kept TCP. ref: https://github.com/castwide/solargraph/issues/65

The author will take a look at stdio again but it would make sense for Oni to support TCP, especially it might be faster.

Contributor guide

Tech stack
typescript
Domain
developer experiencetooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Knowledge of Oni architectureUnderstanding of LSP
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the current language server implementation in Oni, focusing on the communication layer. Look at how stdio is currently used and explore adding a TCP client. Review the Solargraph repository for TCP API details. Check issue comments for any discussions on implementation approach.