Feature - Command Palette: Allow specifying arguments for commands · onivim/oni#1960

(1 comment) (0 reactions) (0 assignees)TypeScript (11,389 stars) (336 forks)batch import

enhancementhelp wantedinsider

Description

This came up in the context of #1947 - it'd be really convenient when opening a browser window to specify a URL, directly from the command palette:

For example, if I start typing bro and then a space and then http://onivim.io, that would make opening a web browser much more convenient.

Today, we can't do that, since our fuzzy filtering tries to match the whole search string: args-to-command

To implement this, we might need to add a custom filter strategy for the command palette window (such that it only uses the first token in the string), and then update the Tasks provider (which backs the command palette) to send back any arguments. That code is around here: https://github.com/onivim/oni/blob/8186d0ba5754282b81464748355ad702d5a4f8e5/browser/src/Services/Tasks.ts#L78

Tech stack: typescriptelectron
Domain: frontend
Issue type: feature
Difficulty: 3
Estimated time: half day
Activity status: stale
Clarity: clear
Prerequisites: TypeScriptOni development setup
Newbie friendliness: 65
Research direction: Research the current command palette implementation, particularly the fuzzy filter in the Tasks provider at browser/src/Services/Tasks.ts. Understand how commands are matched and executed. Consider adding a custom filter strategy that only uses the first token for matching, and pass the remaining tokens as arguments to the command. Also review any existing tests for command palette to ensure no regressions.