onivim/oni

Investigate integrating `nvim_ui_set_option`

Open

#1,953 opened on Mar 28, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (11,389 stars) (336 forks)batch import
enhancementhelp wanted

Description

Pulling this from #992 - @justinmk mentioned that we could potentially use nvim_ui_set_option to change some of our UI externalization options during runtime: https://github.com/neovim/neovim/commit/6e5cb0debd23693175bd05409d3f1af4015567df

Today, if you change an option that depends on an externalized UI flag, like ext_commandline (like changing commandline.mode, which in turn controls ext_commandline), you need to restart Oni for the change to take effect.

It's a much better experience if we can 'hot load' the configuration settings and display the change immediately, so would be cool to leverage nvim_ui_set_option for this.

Note that it's enabled in an unreleased build, so we'd want to grab one of the nightly builds to test it out (and override the nvim instance used by setting debug.neovimPath)

Contributor guide

Tech stack
typescript
Domain
frontenddeveloper experience
Issue type
research
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Neovim UI externalizationOni option handlingBuild and run Oninvim ui set option API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Look at the referenced Neovim commit (6e5cb0debd23693175bd05409d3f1af4015567df) to understand the nvim ui set option function. Then examine Oni's source code to see how options like ext commandline are currently handled and where the UI externalization options are set. Use a nightly Neovim build to test the functionality and determine if the option can be called at runtime to change settings without restart. Provide a summary of findings in the issue comments.
Investigate integrating `nvim_ui_set_option` · onivim/oni#1953 | Good First Issue