onivim/oni

After config.tsx is changed. config.js is not re-generated

Open

#1934 opened on Mar 26, 2018

View on GitHub
 (21 comments) (0 reactions) (0 assignees)TypeScript (11,389 stars) (336 forks)batch import
bughelp wanted

Description

After working for a while, changes to config.tsx no longer regenerates config.js. Tried restarting, stripping down config.tsx, touching config.js, etc. It started working again after I chose Preferences > Edit Oni config (which also help verify that I was editing the right copy of config.tsx.

Can't reproduce anymore.

v0.3.1

Contributor guide

Tech stack
typescriptreact
Domain
build system
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
unclear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
10
Research direction
The issue is about a watcher not regenerating config.js on config.tsx change, but it is not reproducible. Investigate the file watching or build system, possibly in the scripts or Electron main process that compiles TypeScript. Examine how the 'Edit Oni config' command triggers regeneration, as that seemed to fix the issue. Consider any race conditions or file system issues that might cause the watcher to miss changes.