onivim/oni

After config.tsx is changed. config.js is not re-generated

Open

#1,934 opened on Mar 26, 2018

View on GitHub
 (21 comments) (0 reactions) (0 assignees)TypeScript (336 forks)batch import
bughelp wanted

Repository metrics

Stars
 (11,389 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

After working for a while, changes to config.tsx no longer regenerates config.js. Tried restarting, stripping down config.tsx, touching config.js, etc. It started working again after I chose Preferences > Edit Oni config (which also help verify that I was editing the right copy of config.tsx.

Can't reproduce anymore.

v0.3.1

Contributor guide

Research direction
Investigate the file change detection mechanism for config.tsx. Look at how changes are watched and trigger regeneration of config.js. Check for any caching or debouncing that might prevent regeneration. Consider the config file path and ensure the watcher is monitoring the correct file. Examine the code in the config module and file watcher service.
Tech stack
typescriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Needs investigation
Prerequisites
GitTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55