onivim/oni

Draw underlines and undercurls from NeoVim.

Open

#1931 opened on Mar 26, 2018

View on GitHub
 (14 comments) (4 reactions) (0 assignees)TypeScript (11,389 stars) (336 forks)batch import
bountybughelp wantedinsider

Description

I had a spellchecker configured in my Neovim-Qt, and Oni does not underline the spelling errors in my markdown files. While the ]s works.

image

By the way, it is super impressive how smoothly Oni merged my init.vim with plugins and statusline. I didn't even notice when it started using my init.vim. Amazing work. Thank you.

Contributor guide

Tech stack
typescriptelectronreact
Domain
desktopfrontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
basic knowledge of Oniunderstanding of Neovim spellcheck
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
The issue requests that Oni draws underlines and undercurls for Neovim's spellcheck. To implement this, investigate how Oni currently handles Neovim extmarks and rendering of virtual text. Check the rendering pipeline in the Oni codebase, likely in the editor or buffer layer. Look for existing handling of spelling errors and where underlines are drawn for other highlights. The discussion in the issue may contain hints about the approach.