onivim/oni

When tabs.mode == "buffers", moving/closing tabs is broken

Open

#1,768 opened on Mar 10, 2018

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)TypeScript (297 forks)batch import
bughelp wanted

Repository metrics

Stars
 (11,246 stars)
PR merge metrics
 (PR metrics pending)

Description

I recently fixed the issue for tabs mode, but it seems like there is another bug affecting the tabs when in buffers mode.

How to reproduce:

  • Open a folder with 5-6 files
  • Open all the files as tabs
  • Attempt to select each one of them

What happens:

  • At some point it becomes impossible to select a tab
  • Even though tabs are not displayed as select, the Neovim editor still displays the content of the file clicked

Screen recording

Contributor guide

Research direction
Examine the tabs mode logic for buffers mode and trace the selection handler.
Tech stack
typescript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70