onivim/oni

Cmd + clicking a link should open the URL in the browser

Open

#1,757 opened on Mar 9, 2018

View on GitHubContributor guide
 (1 comment) (1 reaction) (0 assignees)TypeScript (297 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (11,246 stars)
PR merge metrics
 (PR metrics pending)

Description

This is a quite small improvement, but would allow to:

We could mimick the behavior of VSCode and:

  • Coloring the link in an "active" color (link blue?) when hovering it with Cmd pressed
  • Display a tooltip stating "Cmd + Click to follow the link" or something like that when hovering it without holding Cmd

I guess the key should be configurable so that it works on all platforms

Contributor guide

Research direction
Investigate how links are currently rendered and handled in the editor. Look for click event handlers and tooltip implementations. Identify where link colors are defined. Then trace the path from rendering to interaction to understand where to add Cmd+click behavior.
Tech stack
typescript
Domain
frontenddeveloper experience
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75