onivim/oni

Outline showing on Menu when clicking on it with mouse

Open

#1750 opened on Mar 8, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (11,389 stars) (336 forks)batch import
bughelp wanted

Description

I was playing around with the Menu (QuickOpen - Control+P / Command Palette - Control+Shift+P), and just noticed that when clicking inside the menu, we get a yellow outline border:

image

I believe this may be a result / regression from switching to react-virtualized. Might just need some styling tweaks on one of the containers here: https://github.com/onivim/oni/blob/bffb10f4c9808261259061bb0f9416a351b555c0/browser/src/Services/Menu/MenuComponent.tsx#L86

Contributor guide