onivim/oni

Outline showing on Menu when clicking on it with mouse

Open

#1,750 opened on Mar 8, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (336 forks)batch import
bughelp wanted

Repository metrics

Stars
 (11,389 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I was playing around with the Menu (QuickOpen - Control+P / Command Palette - Control+Shift+P), and just noticed that when clicking inside the menu, we get a yellow outline border:

image

I believe this may be a result / regression from switching to react-virtualized. Might just need some styling tweaks on one of the containers here: https://github.com/onivim/oni/blob/bffb10f4c9808261259061bb0f9416a351b555c0/browser/src/Services/Menu/MenuComponent.tsx#L86

Contributor guide

Research direction
Examine MenuComponent.tsx around line 86 and apply CSS to remove the yellow outline on focus or active state, e.g., `outline: none` on the container.
Tech stack
typescriptreactcss
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
CSS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85