onivim/oni

TextMate Highlighting: Highlighting doesn't work after jump

Open

#1,584 opened on Feb 19, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (336 forks)batch import
bughelp wantedinsider

Repository metrics

Stars
 (11,389 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

  • I have a file with 154 lines of code
  • 62 of them are visible, cursor is at the first line
  • :60
  • z<Enter> brings line 60 to the top of the 'viewport'

Now all lines below are not highlighted. After I move a line down, TextMate highlighting kicks in. Probably related to #1256. My version is 44e162d359c6b2a669

Contributor guide

Research direction
Investigate the rendering logic after viewport jump. Look at how TextMate highlighting is triggered and why it might skip lines below the jump target.
Tech stack
typescript
Domain
frontenddeveloper experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70