onivim/oni

TextMate Highlighting: Highlighting doesn't work after jump

Open

#1,584 opened on Feb 19, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (11,389 stars) (336 forks)batch import
bughelp wantedinsider

Description

  • I have a file with 154 lines of code
  • 62 of them are visible, cursor is at the first line
  • :60
  • z<Enter> brings line 60 to the top of the 'viewport'

Now all lines below are not highlighted. After I move a line down, TextMate highlighting kicks in. Probably related to #1256. My version is 44e162d359c6b2a669

Contributor guide

Tech stack
typescript
Domain
desktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
basic understanding of Oni's rendering
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the TextMate highlighting update logic in Oni. The issue reports that after a jump command (e.g., `:60` then `z<Enter>`), lines below the cursor stop being highlighted. Examine the code responsible for triggering re highlighting, possibly in the textmate syntax tokenizer or view rendering. Look at related issue #1256 for potential clues. The bug may be in how the viewport change is handled.