onivim/oni

Many errors and warnings in devtools console

Open

#1261 opened on Jan 9, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)TypeScript (11,389 stars) (336 forks)batch import
bughelp wantedinsider

Description

I'm seeing many errors and warnings in the console while typing and jumping around files. Might be something in my config?

(these errors are a pain to type. for some reason I can't copy from the console directly 😢 )

Version: 0.2.20

Oni Config

module.exports = {
   activate,
   deactivate,
  "editor.maximizeScreenOnStart": true,
  "oni.useDefaultConfig": false,
  "oni.loadInitVim": true,
  "ui.fontSmoothing": "subpixel-antialiased",
  "ui.colorscheme": "molokai",
  "editor.fontFamily": "Hack",
  "ui.fontFamily": "Hack",
  "language.javascript.languageServer.argument": ["--no-port-file"]
}

Errors

Warning: Each child in an array or iterator should have a unique "key" prop.

Check the render method of `s`. See https://fb.me/react-warning-keys for more information
      in div  (created by s)

Warning: Encountered two children with the same key, `2red`.
Keys should be unique so that components maintain their
identity across updates. Non-unique keys may cause children to be 
duplicated and/or omitted - the behavior is unsupported and 
could change in a future version
   in div (created by styled.div)

Warnings

Error: No content available.
  at TypeScriptServerHost._parseResponse (TypeScriptServerHost.ts:292)
  at Interface.<anonymous> (TypeScriptServerHost.ts:75)
  at emitOne (events.js:115)

Contributor guide

Tech stack
typescriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic knowledge of ReactUnderstanding of TypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The issue reports two types of warnings: React missing key prop warnings and a TypeScript server error 'No content available.' For the key warnings, search for components that render lists without unique keys, such as file tabs or suggestions. Look in the styled.div components. For the TypeScript error, check TypeScriptServerHost.ts line 292 in the parseResponse method and handle the case where content is empty. A PR might involve adding unique keys to list items and adding a null check for parsed content.