onivim/oni

Colorscheme solarized8_light has dark background after startup

Open

#1,260 opened on Jan 9, 2018

View on GitHub
 (3 comments) (0 reactions) (0 assignees)TypeScript (11,389 stars) (336 forks)batch import
bughelp wanted

Description

The colorscheme solarized8_light has dark background after startup. The default config is used except for "ui.colorscheme": "solarized8_light"

OS: macOS 10.13.2 Oni version: 0.2.20

image

Contributor guide

Tech stack
typescript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
Oni basicscolorscheme understanding
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate how Oni initializes UI colorscheme on startup. Check the core UI initialization code, possibly in 'src/UI/' and 'src/Plugins/' directories. Look for where the colorscheme setting is applied when the editor starts. Compare with expected behavior in light themes.