onivim/oni

[UI] Brief flicker on using Alt to close menu bar

Open

#1,250 opened on Jan 8, 2018

View on GitHub
 (8 comments) (0 reactions) (0 assignees)TypeScript (336 forks)batch import
bugdaily-editor-blockerhelp wanted

Repository metrics

Stars
 (11,389 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

This is just a tiny thing (and possibly purely caused by Electron?)

When menu bar is hidden (so that it can be opened using Alt), closing it will cause a little flicker at the bottom of the screen, apparently the same height as the menu bar.

Would be nice to have it fixed!

Demo of the bug: https://gfycat.com/AnchoredWideBarnacle

Contributor guide

Research direction
Investigate the menu bar toggle logic in the Electron main process and renderer process to identify the cause of the flicker when hiding the menu bar using Alt key.
Tech stack
typescriptelectron
Domain
frontenddesktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScriptElectron
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75